Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/arch

Le 17/02/2018 à 21:56, Joerg Sonnenberger a écrit :
On Sat, Feb 17, 2018 at 06:51:53PM +0000, Maxime Villard wrote:
Module Name:	src
Committed By:	maxv
Date:		Sat Feb 17 18:51:53 UTC 2018

Modified Files:
	src/sys/arch/amd64/amd64: vector.S
	src/sys/arch/i386/i386: vector.S
	src/sys/arch/x86/include: intr.h
	src/sys/arch/x86/x86: i8259.c intr.c
	src/sys/arch/xen/x86: pintr.c

Log Message:
Rename i8259_stubs -> legacy_stubs. We will want the entries to have the
same name, eg:

		-> Xintr_legacy0, Xrecurse_legacy0, Xresume_legacy0
		-> Xintr_legacy1, Xrecurse_legacy1, Xresume_legacy1

I find this change confusing. i8259 is pretty explicit on what it means.
legacy is not clear at all. Is non-MSI(X) legacy?

I couldn't come up with something better. There are two choices:

 * Rename i8259_stubs -> legacy_stubs. We lose i8259, so the name is not

 * Rename Xintr_legacyNN -> Xintr_i8259NN, which is even more confusing,
   because the name of the controller ends with numbers, and we are
   concatenating more numbers.


Home | Main Index | Thread Index | Old Index