re: CVS commit: src/lib/libkvm

[matthew green <mrg%eterna.com.au@localhost>]

matthew green writes:
> "Maxime Villard" writes:
> > Module Name:	src
> > Committed By:	maxv
> > Date:		Wed Feb  7 14:03:18 UTC 2018
> > 
> > Modified Files:
> > 	src/lib/libkvm: kvm.c
> > 
> > Log Message:
> > Keep /dev/ksyms open in _kvm_open(). This way /dev/ksyms can be put into
> > $g_kmem without breaking the tools that need kmem+ksyms.
> > 
> > Discussed on tech-kern@ three weeks ago. The original issue was reported
> > by maya@, the patch was written by Tom Ivar Helbekkmo, ok christos@.
> 
> hmmm, it just occurs to me that this is not safe against me
> re-opening /proc/mypid/N to get another fd on /dev/ksyms as
> a normal user.
> 
> i wonder if this pattern exists elsewhere...

ah, it shouldn't be a problem -- the user/group/mode are
taken from the original file, so whatever /dev/ksyms is.


.mrg.