Re: CVS commit: src/sys/nfs

[Maxime Villard <max%m00nbsd.net@localhost>]

Le 25/01/2018 à 18:14, Taylor R Campbell a écrit :
> Module Name:	src
> Committed By:	riastradh
> Date:		Thu Jan 25 17:14:36 UTC 2018
>
> Modified Files:
> 	src/sys/nfs: nfs.h nfs_syscalls.c
>
> Log Message:
> Use a random opaque cookie, not kva pointer, for nfssvc(2).
>
> (What were they smoking?!)
>
> I suspect most of this is actually dead code that wasn't properly
> amputated along with the rest of the gangrene of NFSKERB a decade
> ago, but I'm out of time to investigate further.  If someone else
> wants to kill NFSSVC_AUTHIN/NFSSVC_AUTHINFAIL and the rest of the
> tentacular kerberosity, be my guest.

I noticed this issue a long time ago too. While it's clear that this hack was
utter garbage, it wasn't essentially critical since the path that leads to this
place is privileged, and basically there's everywhere the assumption that only
the privileged NFS daemon will invoke these syscalls.