Re: CVS commit: src/sys/compat

[Maxime Villard <max%m00nbsd.net@localhost>]

Le 08/12/2017 à 16:31, Robert Elz a écrit :
> Module Name:	src
> Committed By:	kre
> Date:		Fri Dec  8 15:31:13 UTC 2017
>
> Modified Files:
> 	src/sys/compat/linux/common: linux_mod.c
> 	src/sys/compat/linux32/common: linux32_mod.c
>
> Log Message:
> Finish the previous change - as well as setting the default for these
> compat modules back to enabled, stop forcing it to switch back to
> disabled any time the module is init'd (which is truly barbaric behaviour.)
>
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.8 -r1.9 src/sys/compat/linux/common/linux_mod.c
> cvs rdiff -u -r1.9 -r1.10 src/sys/compat/linux32/common/linux32_mod.c
>
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.

No, it wasn't barbaric, it made perfect sense: when modloaded the linux
execsw is not registered, and therefore resetting linux_enabled to zero
forced the user to go through linux_sysctl_enable(), which would register
the execsw normally.

By the way, it looks like Joerg's partial revert does not work, because
if compat_linux is enabled by default then we want exec_add() to be called
by default in MODULE_CMD_INIT. (Haven't tested though.)

Maxime