Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/tests/lib/libc/locale



On Fri, Nov 24, 2017 at 09:30:43PM +0000, Robert Elz wrote:
> Module Name:	src
> Committed By:	kre
> Date:		Fri Nov 24 21:30:43 UTC 2017
> 
> Modified Files:
> 	src/tests/lib/libc/locale: t_sprintf.c
> 
> Log Message:
> When comparing doubles (any floating point values) which have been
> computed using different methods, don't expect to achieve identical
> results (here, one constant is perhaps converted to binary from a string by
> a cross compiler, the other is converted at run time).   Allow them to
> have a small difference (for now, small is < 1e-7 - the constant is ~ 1e5,
> so this is 12 orders of magnitude less) before failing (and include the
> actual difference in the error message if it does fail.) 

I don't agree with this. Parsing a string constant is a well-defined
operation with precise result. A cross-compiler that doesn't do that
correctly is simply broken.

Joerg


Home | Main Index | Thread Index | Old Index