Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

re: CVS commit: src



thanks for working on this.

> * Update the data structures used for exporting kernel history data to
>   include a version number as well as the length of history arguments.

so, old vmstat breaks for no reason?  nothing else changed, right?

> * All [2] existing users of kernhist(9) have had instances of "%s" or
>   "%c" format strings replaced with numeric formats; several instances
>   of mis-match between format string and argument list have been fixed.

i wonder if we could have an audit mode.  it would actually
pass the arguments to a printf()-like function so the compiler
would do checking.

> * vmstat(1) now checks the version and argument length included in the
>   data exported via sysctl(9) and exits if they do not match the values
>   with which vmstat was built.

that's not how we do sysctl.  if we were just going to do this
we may as well just do kvm.  sysctl should be ABI stable.

please revert all the ABI changes.  they're not necessary and
they're just not how sysctl is done.

thanks.


.mrg.


Home | Main Index | Thread Index | Old Index