Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sbin/resize_ffs



>Module Name:    src
>Committed By:   riastradh
>Date:           Sat Sep 30 15:25:16 UTC 2017
>
>Modified Files:
>        src/sbin/resize_ffs: resize_ffs.c
>
>Log Message:
>Use int64_t for loop index so we don't iterate forever/until trap.

Hello,

This causes a build failure because of missing brackets around the if
statement:

In file included from /usr/include/prop/plistref.h:36:0,
                 from /usr/include/sys/dkio.h:36,
                 from /usr/include/sys/disk.h:82,
                 from resize_ffs.c:41:
resize_ffs.c: In function 'initcg':
resize_ffs.c:568:3: error: expected expression before '__int64_t'
   int64_t di;
   ^
resize_ffs.c:569:8: error: 'di' undeclared (first use in this function)
   for (di = 0; di < dlow; di += newsb->fs_frag) {
        ^
resize_ffs.c:569:8: note: each undeclared identifier is reported only
once for each function it appears in
*** Error code 1

Stop.
make: stopped in /home/disciple/netbsd-current/src/sbin/resize_ffs

--- resize_ffs.c.orig   2017-09-30 17:49:25.261323156 +0000
+++ resize_ffs.c        2017-09-30 18:11:50.545676615 +0000
@@ -564,7 +564,7 @@
         * below for the post-inode data area, is that the pre-sb data
         * area always starts at 0, and thus is block-aligned, and
         * always ends at the sb, which is block-aligned.) */
-       if ((newsb->fs_old_flags & FS_FLAGS_UPDATED) == 0)
+       if ((newsb->fs_old_flags & FS_FLAGS_UPDATED) == 0) {
                int64_t di;
                for (di = 0; di < dlow; di += newsb->fs_frag) {
                        old_cg_blktot(cg, 0)[old_cbtocylno(newsb,
di)]++;
@@ -572,6 +572,7 @@
                            old_cbtocylno(newsb, di),
                            0)[old_cbtorpos(newsb, di)]++;
                }
+       }
 
        /* Deal with a partial block at the beginning of the post-inode
area.
         * I'm not convinced this can happen - I think the inodes are
always

Regards,

Dave



Home | Main Index | Thread Index | Old Index