Re: CVS commit: src

[Paul Goyette <paul%whooppee.com@localhost>]

Shouldn't this require a system version bump?

On Mon, 28 Aug 2017, Kamil Rytarowski wrote:

> Module Name:	src
> Committed By:	kamil
> Date:		Mon Aug 28 00:46:07 UTC 2017
>
> Modified Files:
> 	src/bin/ps: ps.1
> 	src/doc: TODO.ptrace
> 	src/sbin/mount_procfs: mount_procfs.8
> 	src/share/man/man9: kauth.9
> 	src/sys/compat/linux/arch/arm: linux_ptrace.c
> 	src/sys/compat/linux/arch/i386: linux_ptrace.c
> 	src/sys/compat/linux/arch/powerpc: linux_ptrace.c
> 	src/sys/kern: kern_exit.c kern_proc.c kern_sig.c sys_ptrace_common.c
> 	src/sys/miscfs/procfs: files.procfs procfs.h procfs_subr.c
> 	    procfs_vfsops.c procfs_vnops.c
> 	src/sys/modules/procfs: Makefile
> 	src/sys/sys: kauth.h proc.h sysctl.h
> Removed Files:
> 	src/sys/miscfs/procfs: procfs_ctl.c
>
> Log Message:
> Remove the filesystem tracing feature
>
> This is a legacy interface from 4.4BSD, and it was
> introduced to overcome shortcomings of ptrace(2) at that time, which are
> no longer relevant (performance). Today /proc/#/ctl offers a narrow
> subset of ptrace(2) commands and is not applicable for modern
> applications use beyond simplistic tracing scenarios.
>
> This removal will simplify kernel internals. Users will still be able to
> use all the other /proc files.
>
> This change won't affect other procfs files neither Linux compat
> features within mount_procfs(8). /proc/#/ctl isn't available on Linux.
>
> Remove:
> - /proc/#/ctl from mount_procfs(8)
> - P_FSTRACE note from the documentation of ps(1)
> - /proc/#/ctl and filesystem tracing documentation from mount_procfs(8)
> - KAUTH_REQ_PROCESS_PROCFS_CTL documentation from kauth(9)
> - source code file miscfs/procfs/procfs_ctl.c
> - PFSctl and procfs_doctl() from sys/miscfs/procfs/procfs.h
> - KAUTH_REQ_PROCESS_PROCFS_CTL from sys/sys/kauth.h
> - PSL_FSTRACE (0x00010000) from sys/sys/proc.h
> - P_FSTRACE (0x00010000) from sys/sys/sysctl.h
>
> Reduce code complexity after removal of this functionality.
>
> Update TODO.ptrace accordingly: remove two entries about /proc tracing.
>
> Do not keep legacy notes as comments in the headers about removed
> PSL_FSTRACE / P_FSTRACE, as this interface had little number of users
> (close or equal to zero).
>
> Proposed on tech-kern@.
>
> All filesystem tracing utility users are encouraged to switch to ptrace(2).
>
> Sponsored by <The NetBSD Foundation>
>
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.107 -r1.108 src/bin/ps/ps.1
> cvs rdiff -u -r1.28 -r1.29 src/doc/TODO.ptrace
> cvs rdiff -u -r1.35 -r1.36 src/sbin/mount_procfs/mount_procfs.8
> cvs rdiff -u -r1.108 -r1.109 src/share/man/man9/kauth.9
> cvs rdiff -u -r1.19 -r1.20 src/sys/compat/linux/arch/arm/linux_ptrace.c
> cvs rdiff -u -r1.31 -r1.32 src/sys/compat/linux/arch/i386/linux_ptrace.c
> cvs rdiff -u -r1.29 -r1.30 src/sys/compat/linux/arch/powerpc/linux_ptrace.c
> cvs rdiff -u -r1.268 -r1.269 src/sys/kern/kern_exit.c
> cvs rdiff -u -r1.206 -r1.207 src/sys/kern/kern_proc.c
> cvs rdiff -u -r1.336 -r1.337 src/sys/kern/kern_sig.c
> cvs rdiff -u -r1.22 -r1.23 src/sys/kern/sys_ptrace_common.c
> cvs rdiff -u -r1.11 -r1.12 src/sys/miscfs/procfs/files.procfs
> cvs rdiff -u -r1.71 -r1.72 src/sys/miscfs/procfs/procfs.h
> cvs rdiff -u -r1.48 -r0 src/sys/miscfs/procfs/procfs_ctl.c
> cvs rdiff -u -r1.108 -r1.109 src/sys/miscfs/procfs/procfs_subr.c
> cvs rdiff -u -r1.97 -r1.98 src/sys/miscfs/procfs/procfs_vfsops.c
> cvs rdiff -u -r1.197 -r1.198 src/sys/miscfs/procfs/procfs_vnops.c
> cvs rdiff -u -r1.3 -r1.4 src/sys/modules/procfs/Makefile
> cvs rdiff -u -r1.74 -r1.75 src/sys/sys/kauth.h
> cvs rdiff -u -r1.341 -r1.342 src/sys/sys/proc.h
> cvs rdiff -u -r1.223 -r1.224 src/sys/sys/sysctl.h
>
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
>
>
> !DSPAM:59a367f5130345948688372!

+------------------+--------------------------+----------------------------+
| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:          |
| (Retired)        | FA29 0E3B 35AF E8AE 6651 | paul at whooppee dot com   |
| Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd dot org |
+------------------+--------------------------+----------------------------+