Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/arch/amd64/conf



On Tue, 15 Aug 2017, Martin Husemann wrote:

On Tue, Aug 15, 2017 at 04:33:19PM +0200, Maxime Villard wrote:
So we agree? Each compat should be independent.

Yes.

Well, not totally independent! We have module dependencies to enable the use of common code.

It seems to me that
re-implementing (copy-paste) a few functions for linux is a step towards
direction, isn't it?

No, it isn't (but it MAY be ok for real trivial ones).

Untangling the maze, renaming the common functions and fixing the
modularization for them is the way to go, IMO.

Definitely agree here, 110%


BTW, the "new" module we're recommending might better be called compat_utils rather than compat_common.



+------------------+--------------------------+----------------------------+
| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:          |
| (Retired)        | FA29 0E3B 35AF E8AE 6651 | paul at whooppee dot com   |
| Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd dot org |
+------------------+--------------------------+----------------------------+


Home | Main Index | Thread Index | Old Index