re: CVS commit: src/sys/dev/hdaudio

[matthew green <mrg%eterna.com.au@localhost>]

Robert Elz writes:
>     Date:        Fri, 4 Aug 2017 00:25:24 +0000
>     From:        "matthew green" <mrg%netbsd.org@localhost>
>     Message-ID:  <20170804002524.16BA1FACD%cvs.NetBSD.org@localhost>
> 
>   | put all the ELD debugging messages under #ifdef HDAFG_HDMI_DEBUG.
> 
> I am not sure that doing that with the ones that are hda_error() is
> the correct thing to do - if something is failing, getting an indication
> why, even when not debugging. seems like a good idea to me.

this code is not functional and only complains when it fails
to parse stuff, that probably is quite valid.  all it does is
whine, not actually do take any useful action.

ie, it's not useful and actively spams dmesg.  there's a
reasonable chance it is buggy -- it hasn't really been
tested properly or checked against the spec.

if someone wants to make this code work, then these could
be re-promoted, but for now they're garbage.


.mrg.