Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/opencrypto



On Tue, Apr 18, 2017 at 05:05:06PM +0000, Maya Rashish wrote:
> XXX surrounding code seems fishy
> 
> @@ -759,7 +759,6 @@ swcr_compdec(struct cryptodesc *crd, con
>  	if (result < crd->crd_len) {
>  		adj = result - crd->crd_len;
>  		if (outtype == CRYPTO_BUF_MBUF) {
> -			adj = result - crd->crd_len;
>  			m_adj((struct mbuf *)buf, adj);
>  		}
>  		/* Don't adjust the iov_len, it breaks the kmem_free */
> 


calling m_adj with negative adj sounds possibly unintended


Home | Main Index | Thread Index | Old Index