Re: CVS commit: src/sys/arch

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

On Mon, Apr 17, 2017 at 07:19:28AM +0000, Maya Rashish wrote:
> Module Name:	src
> Committed By:	maya
> Date:		Mon Apr 17 07:19:28 UTC 2017
> 
> Modified Files:
> 	src/sys/arch/amd64/conf: XEN3_DOM0
> 	src/sys/arch/i386/conf: XEN3_DOM0
> 
> Log Message:
> Uncomment MULTIPROCESSOR in dom0 kernels

Are you sure it's OK ?
It's not clear if the backend drivers, and especially the xenstore,
event channels and grant table stuff, are MP safe (I'm almost sure they
are not). There's still some splfoo()/splx() use there.
At minimum we should KASSERT() that the kernel lock is held here.

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--