Re: CVS commit: src/sys/dev

[christos%astron.com@localhost (Christos Zoulas)]

In article <20170221202337.A81E5FBE5%cvs.NetBSD.org@localhost>,
Nathanial Sloss <source-changes-d%NetBSD.org@localhost> wrote:
>-=-=-=-=-=-
>
>virtual_channel *vc)
> {
>+	struct audio_chan *vchan;
>+	bool found = false;

Overinitialization here ^.

> 	int error;
> 
> 	KASSERT(mutex_owned(sc->sc_lock));
>@@ -1526,6 +1529,16 @@ audio_waitio(struct audio_softc *sc, kco
> 	/* Wait for pending I/O to complete. */
> }

But really, are you overwriting the error? Perhaps:

 	error = cv_wait_sig(chan, sc->sc_lock);
	if (error)
		return error;
 
	SIMPLEQ_FOREACH(vchan, &sc->sc_audiochan, entries) {
		if (vchan->vc == vc)
			return 0;
	}

	return EIO;