Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

re: CVS commit: src/sys/kern



"Christos Zoulas" writes:
> Module Name:	src
> Committed By:	christos
> Date:		Thu Jan 26 15:54:31 UTC 2017
> 
> Modified Files:
> 	src/sys/kern: kern_proc.c
> 
> Log Message:
> use __HAVE_COMPAT_NETBSD32

this is ugly.  and gross.  we should be removing refs to
compat code from the base kernel, not adding them.

why can't this be in the compat code?  eg, move the
compat crap in copyin_psstrings() into the compat code and
access it via the emul.

then the code for it lives where it should, and no one needs
to have special crap they don't need or want.

at the very least, this should be restricted to MODULAR
kernels -- it's *only* useful for the case where you have
MODULAR enabled but don't have the compat modules loaded,
which is not how GENERIC works, nor most people not
working directly on the module system.

thanks.


.mrg.


Home | Main Index | Thread Index | Old Index