Re: CVS commit: src/sys/netinet

[bch <brad.harder%gmail.com@localhost>]

On 1/1/17, Christos Zoulas <christos%netbsd.org@localhost> wrote:
> Module Name:	src
> Committed By:	christos
> Date:		Mon Jan  2 01:18:42 UTC 2017
>
> Modified Files:
> 	src/sys/netinet: tcp.h tcp_input.c tcp_output.c tcp_subr.c
>
> Log Message:
> Fix TCP signature code:
> 1. pack options more tightly instead of being generous with no/op
> 2. put TCP_SIGNATURE option before SACK
> 3. fix computation of options length, by deferring it
> XXX: Really we should move the options setting code in one place instead
> of having two copies one for input and one for output.
> XXX: tcp_optlen/tcp_hdrsiz need to be fixed; they were wrong before too.
>

New build failure:


[...]
--- tcp_output.o ---
/usr/src/sys/netinet/tcp_output.c: In function 'tcp_output':
/usr/src/sys/netinet/tcp_output.c:1298:4: error: label 'reset' used
but not defined
    goto reset;
    ^
*** [tcp_output.o] Error code 1
[...]




> To generate a diff of this commit:
> cvs rdiff -u -r1.31 -r1.32 src/sys/netinet/tcp.h
> cvs rdiff -u -r1.351 -r1.352 src/sys/netinet/tcp_input.c
> cvs rdiff -u -r1.187 -r1.188 src/sys/netinet/tcp_output.c
> cvs rdiff -u -r1.268 -r1.269 src/sys/netinet/tcp_subr.c
>
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
>
>