Le 11/12/2016 à 17:08, Maxime Villard a écrit :
Le 11/12/2016 à 16:37, Martin Husemann a écrit :
On Sun, Dec 11, 2016 at 08:31:53AM +0000, Maxime Villard wrote:
Module Name: src
Committed By: maxv
Date: Sun Dec 11 08:31:53 UTC 2016
Modified Files:
src/sys/arch/amd64/amd64: machdep.c
src/sys/arch/i386/i386: machdep.c
src/sys/arch/x86/x86: pmap.c
Log Message:
Kenter local_apic_va to a fake physical page, because our x86
implementation expects this va to be valid even if no lapic is present;
which probably is a bug in itself, but let's just reproduce the old
behavior and rehide that bug.
i386 kernels do not build for me with this change (local_apic_va being
undefined in machdep.c).
Really? I did test this change on both i386 and amd64, with and without
lapic (with virtualbox). I don't have access to my main machine now; but
simply looking at the code, machdep.c includes <machine/acpi_machdep.h>,
which includes <machine/i82489var.h>, which exports local_apic_va.
It does indeed rely on NACPICA to be defined, but I don't think I
changed my configuration, it's the default build.
[I'm forwarding this to source-changes]
Le 11/12/2016 à 20:50, Martin Husemann a écrit :
http://releng.netbsd.org/builds/HEAD/201612111020Z/i386.build.failed
building standard kern library
building standard kern library
/home/source/ab/HEAD/src/sys/arch/i386/i386/machdep.c: In function
'init386':
/home/source/ab/HEAD/src/sys/arch/i386/i386/machdep.c:1305:17: error:
'local_apic_va' undeclared (first use in this function)
pmap_kenter_pa(local_apic_va, local_apic_pa,
^
/home/source/ab/HEAD/src/sys/arch/i386/i386/machdep.c:1305:17: note: each
undeclared identifier is reported only once for each function it appears
in
I saw it with a custom kernel, but same issue.
Martin
? Well perhaps I was compiling with a different configuration, but that
would surprise me. I'm not sure I'll be able to fix it in the next few
days - feel free to do it if you want to, otherwise you'll probably have
to wait a bit...
(sorry about that)