Re: CVS commit: src/sys/compat/netbsd32

[Rin Okuyama <rokuyama%rk.phys.keio.ac.jp@localhost>]

On 2016/11/15 8:16, matthew green wrote:
> "Rin Okuyama" writes:
> > Module Name:	src
> > Committed By:	rin
> > Date:		Sun Nov 13 13:59:45 UTC 2016
> >
> > Modified Files:
> > 	src/sys/compat/netbsd32: netbsd32_conv.h
> >
> > Log Message:
> > correct wrong casting. some are considered harmless, but
> > - tv_sec in netbsd32_timeval is netbsd32_time_t (aka netbsd32_int64_t)
> >   rather than time_t (int64_t)
> > - tv_sec in netbsd32_timespec is netbsd32_time_t rather than
> >   netbsd32_long (y2038 problem)
> > approved by martin
>
> i didn't look closely, but note that netbsd 5.0 had different
> time_t -- it was only 32 bits.
>
> please check the compat50 and earlier code works fine with this.

I've checked that i386 binaries from 5.2.2 work on amd64. The point is
that netbsd32_time{val,spec}50 are converted into/from time{val,spec}.
Not time{val,spec}50. Function names netbsd32_{to,from}_time{val,spec}50
may be misleading, although they conform to the naming rules...

Thanks,
Rin