Re: CVS commit: src/sys/arch/amiga

[Michael <macallan%netbsd.org@localhost>]

Hello,

On Mon, 3 Oct 2016 14:26:02 +0000
"Radoslaw Kujawa" <rkujawa%netbsd.org@localhost> wrote:

> Module Name:	src
> Committed By:	rkujawa
> Date:		Mon Oct  3 14:26:02 UTC 2016
> 
> Modified Files:
> 	src/sys/arch/amiga/amiga: conf.c
> 	src/sys/arch/amiga/conf: WSCONS files.amiga
> 	src/sys/arch/amiga/dev: zbus.c
> Added Files:
> 	src/sys/arch/amiga/dev: mntva.c mntvareg.h mntvavar.h
> 
> Log Message:
> Add a driver for MNTMN VA2000.
> 
> Supports accelerated wsdisplay console and running X via wsfb driver.

On 2nd glance, some suggestions:
- I'd wrap putchar() and only wait for the blitter if we actually need
  to draw something or issue another blitter command, and use rectfill
  for whitespaces
- also, glyphcache will help you avoid framebuffer writes. My drivers
  only use it for antialiased fonts but since this chip doesn't seem to
  have colour expansion you may want to use it for bitmap fonts as well

have fun
Michael