Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/arch



On Fri, Aug 05, 2016 at 10:44:14AM +0200, Maxime Villard wrote:
> Le 04/08/2016 à 21:09, Joerg Sonnenberger a écrit :
> > On Sun, Jul 24, 2016 at 02:09:22PM +0000, Maxime Villard wrote:
> > > Fix this by properly saving and restoring the EFER MSR. It's a little
> > > tricky since the wakeup code uses %edx, but rdmsr overwrites it. We just
> > > save it in %esi.
> > 
> > Use push/pop around it, please?
> > 
> 
> Around what, where?

The %edx reinit in acpi_md_sleep_prepare. Just push edx / pop edx around
the rdmsr with a comment about clobbering. Less work to understand what
goes on and certainly not more code either.

Joerg


Home | Main Index | Thread Index | Old Index