Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/sys



(from a while back)

On Sun, Jan 24, 2016 at 02:11:56PM +0100, Joerg Sonnenberger wrote:
 > On Fri, Jan 22, 2016 at 11:31:30PM +0000, David A. Holland wrote:
 > > Module Name:	src
 > > Committed By:	dholland
 > > Date:		Fri Jan 22 23:31:30 UTC 2016
 > > 
 > > Modified Files:
 > > 	src/sys/sys: dirent.h
 > > 
 > > Log Message:
 > > Uses __GNUC_PREREQ__, needs sys/cdefs.h.
 > 
 > I wonder if including stddef.h / libkern.h and using the real offsetof
 > would be better.

Wouldn't help; the GNUC_PREREQ is there because it uses typeof. Which
it needs to do, because the macro in question needs to be polymorphic
over struct dirent and also struct direct from FFS. *That* is what
ought to be tidied up.

-- 
David A. Holland
dholland%netbsd.org@localhost


Home | Main Index | Thread Index | Old Index