Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/tests/net/route



On Tue, Jun 21, 2016 at 7:35 PM, Paul Goyette <paul%whooppee.com@localhost> wrote:
> On Tue, 21 Jun 2016, Ryota Ozaki wrote:
>
>> Module Name:    src
>> Committed By:   ozaki-r
>> Date:           Tue Jun 21 10:18:27 UTC 2016
>>
>> Modified Files:
>>         src/tests/net/route: t_route.sh
>>
>> Log Message:
>> Tweak route get outputs to make tests work
>>
>> "expire" value of route get output is unexpectedly a negative value
>> on rump kernel for some reasons and the tests almost always fail
>> on babylon5. So just ignore it to make tests work for now. Should
>> fix it in the future.
>
>
> Wouldn't it be better to mark the test as "Expected Failure" ?

No because the tests pass on normal (fast enough?) machines,
although the tests sometimes fail even on such machines (I guess
because of load).

I guess the unexpected behavior stems from rump.route implementation
(or rump kernel) and doesn't happen on non-rump environments. I don't
have idea to fix it for now.

  ozaki-r


Home | Main Index | Thread Index | Old Index