Re: CVS commit: src/sys/arch

[christos%astron.com@localhost (Christos Zoulas)]

In article <20160512133124.GA29240%britannica.bec.de@localhost>,
Joerg Sonnenberger  <joerg%bec.de@localhost> wrote:
>On Thu, May 12, 2016 at 06:45:17AM +0000, Maxime Villard wrote:
>> Module Name:	src
>> Committed By:	maxv
>> Date:		Thu May 12 06:45:16 UTC 2016
>> 
>> Modified Files:
>> 	src/sys/arch/amd64/amd64: locore.S machdep.c
>> 	src/sys/arch/amd64/conf: kern.ldscript
>> 	src/sys/arch/i386/conf: kern.ldscript
>> 	src/sys/arch/i386/i386: locore.S
>> 	src/sys/arch/x86/x86: db_memrw.c pmap.c
>> 
>> Log Message:
>> Split the {text+rodata} chunk in two separate chunks on x86. The
>> rodata segment now loses the large page optimization, gets mapped inside
>> the data segment, and therefore becomes RWX. It may break the build on
>> Xen.
>
>This was not discussed anywhere. I'm not even convinced it is a good
>idea. So why has this been just committed?

Yes, changes like this should be discussed *first*. Also the commit
messages should not just say what was changed but also *why* it was
changed.

Best,

christos