Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/net80211



On Wed, Apr 06, 2016 at 02:42:16PM +0000, Roy Marples wrote:
> Module Name:	src
> Committed By:	roy
> Date:		Wed Apr  6 14:42:16 UTC 2016
> 
> Modified Files:
> 	src/sys/net80211: ieee80211_ioctl.h ieee80211_node.c ieee80211_node.h
> 	    ieee80211_rssadapt.h ieee80211_var.h
> 
> Log Message:
> ieee80211 users in Other OS export rssi and noise as int8_t.
> We should not be the odd one out for no good reason and the majority
> of the ieee80211 drivers treat rssi as int8_t.

This may be a more difficult change to make properly than you
anticipated.  Drivers like rtw(4) assume 0 <= RSSI <= UINT8_MAX.  If you
put those RSSI into an int8_t, then for high signal strengths the number
may change sign instead of increase in magnitude.

Dave

-- 
David Young
dyoung%pobox.com@localhost    Urbana, IL    (217) 721-9981


Home | Main Index | Thread Index | Old Index