Re: CVS commit: src/bin/sh

[Robert Elz <kre%munnari.OZ.AU@localhost>]

    Date:        Sun, 3 Jan 2016 22:00:24 -0500
    From:        "Christos Zoulas" <christos%netbsd.org@localhost>
    Message-ID:  <20160104030024.30647FBB5%cvs.NetBSD.org@localhost>

  | Don't leak redirected rescriptors to exec'ed processes.

I think this is incorrect.   Standard practice has always been that
any open fds in the parent are passed on to the child at fork(), and
remain open through exec() unless they have close-on-exec set (for which
there is no shell syntax, though perhaps there should be).

  | This fixes by side effect the problem of the rc system leaking file
  | descriptors 7 and 8 to all starting daemons:

If that's actually a leak in the rc system (rather than by design because
some sub-shells need the fds - in which case you just broke it) then fixing
it in the scripts would be easy.

It appears from a later message from martin@ that this change has also
broken the build system.

Reverting it would be a very good idea.

kre