Re: CVS commit: src/sbin/gpt

[John Nemeth <jnemeth%cue.bc.ca@localhost>]

On Nov 30,  9:03pm, "Christos Zoulas" wrote:
}
} This is a multi-part message in MIME format.
} 
} --_----------=_1448935435147560
} Content-Disposition: inline
} Content-Transfer-Encoding: 8bit
} Content-Type: text/plain; charset="US-ASCII"
} 
} Module Name:	src
} Committed By:	christos
} Date:		Tue Dec  1 02:03:55 UTC 2015
} 
} Modified Files:
} 	src/sbin/gpt: add.c gpt.c resize.c
} 
} Log Message:
} - use gpt_msg to print informational messages (perhaps these should be printed
}   only with -v)
} - don't print any messages with gpt_msg if quiet
} - print a message if we didn't reconfigure the wedges
} 
} 
} To generate a diff of this commit:
} cvs rdiff -u -r1.29 -r1.30 src/sbin/gpt/add.c
} cvs rdiff -u -r1.47 -r1.48 src/sbin/gpt/gpt.c
} cvs rdiff -u -r1.13 -r1.14 src/sbin/gpt/resize.c
} 
} Please note that diffs are not public domain; they are subject to the
} copyright notices on the relevant files.
} 
} 
} --_----------=_1448935435147560
} Content-Disposition: inline
} Content-Length: 2767
} Content-Transfer-Encoding: binary
} Content-Type: text/x-diff; charset=us-ascii
} 
} Modified files:
} 
} Index: src/sbin/gpt/gpt.c
} diff -u src/sbin/gpt/gpt.c:1.47 src/sbin/gpt/gpt.c:1.48
} --- src/sbin/gpt/gpt.c:1.47	Mon Nov 30 20:49:23 2015
} +++ src/sbin/gpt/gpt.c	Mon Nov 30 21:03:55 2015
} @@ -573,15 +573,22 @@ void
}  gpt_close(int fd)
}  {
}  
} -	if (modified && !nosync) {
} +	if (!modified)
} +		goto out;
} +
} +	if (!nosync) {
}  #ifdef DIOCMWEDGES
}  		int bits;
}  		if (ioctl(fd, DIOCMWEDGES, &bits) == -1)
}  			warn("Can't update wedge information");
} +		else
} +			goto out;
}  #endif
}  	}
} +	gpt_msg("You need to run \"dkctl %s makewedges\""
} +	    " for the changes to take effect\n", device_name);

     dkctl makewedges is just ioctl(DIOCMWEDGES), so if DIOCMWEDGES
doesn't exist or it fails, then dkctl makewedges won't do anything,
which means that the user would either need to use dkctl add, etc.,
or reboot.

}  
} -	/* XXX post processing? */
} +out:
}  	close(fd);
}  }
}  
} --_----------=_1448935435147560--
} 
}-- End of excerpt from "Christos Zoulas"