Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/lib/libpanel



On Sun, Nov 01, 2015 at 09:42:11PM +0700, Robert Elz wrote:
>     Date:        Sun, 1 Nov 2015 11:02:24 +0000
>     From:        "Thomas Klausner" <wiz%netbsd.org@localhost>
>     Message-ID:  <20151101110224.0F63098%cvs.netbsd.org@localhost>
> 
>   | Modified Files:
>   | 	src/lib/libpanel: panel_above.3
>   | 
>   | Log Message:
>   | Improve wording even more, suggested by Robert Elz.
> 
> You changed the of "bottom and top" to "top and bottom".
> 
> While I agree that's a more common usage, if you're going to do
> that you also need to swap the order of the functions.
> 
> panel_above(NULL) -> the bottom panel, panel_below(NULL) -> the top one.
> 
> kre
> 
> ps: I also agree with Paul, the extra "the", while not incorrect, makes
> it harder to read.

The functions don't behave like I thought they would.
I've swapped the words again and removed the 'the'.
 Thomas
 


Home | Main Index | Thread Index | Old Index