Re: CVS commit: src/sys/dev/acpi

[Ryo ONODERA <ryo_on%yk.rim.or.jp@localhost>]

Hi,

From: "Christos Zoulas" <christos%netbsd.org@localhost>, Date: Sat, 26 Sep 2015 09:04:10 -0400

> Module Name:	src
> Committed By:	christos
> Date:		Sat Sep 26 13:04:10 UTC 2015
> 
> Modified Files:
> 	src/sys/dev/acpi: valz_acpi.c
> 
> Log Message:
> CID 1324963: Remove bogus NULL test
> CID 1324962: This is not python, one needs braces too.

CID 1324962 is detected by mistake.
Indent is incorrect and logic is correct.

Could you apply this patch?

Thank you.

> To generate a diff of this commit:
> cvs rdiff -u -r1.5 -r1.6 src/sys/dev/acpi/valz_acpi.c
> 
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
> 

Index: valz_acpi.c
===================================================================
RCS file: /cvsroot/src/sys/dev/acpi/valz_acpi.c,v
retrieving revision 1.6
diff -u -r1.6 valz_acpi.c
--- valz_acpi.c	26 Sep 2015 13:04:10 -0000	1.6
+++ valz_acpi.c	5 Oct 2015 15:47:11 -0000
@@ -420,10 +420,9 @@
 	param = (ACPI_OBJECT *)buf.Pointer;
 	PrtElement = param->Package.Elements;
 	for (i = 0; i < HCI_WORDS; i++) {
-		if (PrtElement->Type == ACPI_TYPE_INTEGER) {
+		if (PrtElement->Type == ACPI_TYPE_INTEGER)
 			output[i] = PrtElement->Integer.Value;
-			PrtElement++;
-		}
+		PrtElement++;
 	}
 
 	ACPI_FREE(buf.Pointer);