Re: CVS commit: src/sys/arch/arm/allwinner

[Jared McNeill <jmcneill%invisible.ca@localhost>]

Instead of an extra line of output, can you change this to use 
your own callback instead of gpiobus_print for config_attach_ia? Here's 
what I do on Tegra:

  http://nxr.netbsd.org/xref/src/sys/arch/arm/nvidia/tegra_gpio.c#196

The result is a lot cleaner (especially since there are 31 instances of 
the gpio driver on Tegra K1):

  gpio0 at tegragpio0 (A): 8 pins
  gpio1 at tegragpio0 (B): 8 pins
  gpio2 at tegragpio0 (C): 8 pins
  gpio3 at tegragpio0 (D): 8 pins
  ...

Cheers,
Jared


On Fri, 2 Oct 2015, Manuel Bouyer wrote:

> Module Name:	src
> Committed By:	bouyer
> Date:		Fri Oct  2 14:06:02 UTC 2015
>
> Modified Files:
> 	src/sys/arch/arm/allwinner: awin_gpio.c
>
> Log Message:
> Print the port name when gpio(4) attaches, makes it much easier to find
> what port is connected to what gpio instance:
> gpio0 at awingpio0: 18 pins
> gpio0: port B
> gpio1 at awingpio0: 25 pins
> gpio1: port C
> gpio2 at awingpio0: 28 pins
> gpio2: port D
> gpio3 at awingpio0: 12 pins
> gpio3: port E
> gpio4 at awingpio0: 12 pins
> gpio4: port G
> gpio5 at awingpio0: 28 pins
> gpio5: port H
> gpio6 at awingpio0: 22 pins
> gpio6: port I
>
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.18 -r1.19 src/sys/arch/arm/allwinner/awin_gpio.c
>
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.