Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/usr.bin/config



On Fri, Aug 28, 2015 at 08:31:28AM +0000, Masao Uebayashi wrote:
> Module Name:	src
> Committed By:	uebayasi
> Date:		Fri Aug 28 08:31:28 UTC 2015
> 
> Modified Files:
> 	src/usr.bin/config: mkmakefile.c
> 
> Log Message:
> Accept only relative paths (from $S) for `file' and `object'.  Simplify code.
> config(1) does not need to be super-smart about path handling, because it is
> usually used with make(1), that is much smarter.
> 
> Pre-compiled object files, specified using `object', are regarded as read-only
> input, thus they should be put under $S (or $S/..), as part of a source tree.

I'm pretty sure the original intent was to allow 3rd party drivers to be
distributed as an object file and a relevant config(5) file to be
included by the user in their GENERIC.  Which is why all the definition
gear is still allowed in the selection phase.  That also mean that
absolute paths for 'file' and 'object' have (had?) merit.

So, if you're discarding that code (I haven't looked at the actual diff)
you might want to consider bumping the syntax version and refusing older
versions.  That would probably get you some anger but hey, at this point
for you it's probably a drop in the ocean :-)

-- 
Quentin Garnier - cube%cubidou.net@localhost
"See the look on my face from staying too long in one place
[...] every time the morning breaks I know I'm closer to falling"
KT Tunstall, Saving My Face, Drastic Fantastic, 2007.

Attachment: pgpnWG7nHAyIU.pgp
Description: PGP signature



Home | Main Index | Thread Index | Old Index