Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/lib/libpthread



On 26/06/15 07:04, Nick Hudson wrote:
On 06/26/15 02:33, Antti Kantee wrote:
+# ifdef __CPU_SIMPLE_LOCK_PAD
+#  define __pthread_spin_t unsigned char
+# else
+#  define __pthread_spin_t unsigned int
+# endif

Are you sure this "works" for hppa which has funky __cpu_simple_lock_t?

Slightly related.  arch/arm has:

/*
 * This should have always been an 8-bit type, but since it's been exposed
 * to user-space, we don't want ABI breakage there.
 */
#if defined(_KERNEL)
typedef volatile unsigned char  __cpu_simple_lock_t;
#else
typedef volatile int            __cpu_simple_lock_t;
#endif /* _KERNEL */


Should that be no ifdef & __CPU_SIMPLE_LOCK_PAD like everywhere else?


Home | Main Index | Thread Index | Old Index