Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Wrong PR e-mails



On Wed, May 13, 2015 at 02:16:00PM +0000, Christos Zoulas wrote:
> No, I feel sorry for you. Perhaps we should modify the script so that
> if it finds more than 2 PR matches it makes the commit fail, or it does
> not add anymore...

I suggest the attached patch (with "more than 3" PRs, but you can
easily change it to "more than 2").
 Thomas
Index: log_accum
===================================================================
RCS file: /cvsroot/CVSROOT/log_accum,v
retrieving revision 1.112
diff -u -r1.112 log_accum
--- log_accum	21 Oct 2014 13:21:08 -0000	1.112
+++ log_accum	14 May 2015 17:52:23 -0000
@@ -433,6 +433,8 @@
     @prs = map { if (!$last || $last ne $_) { $last = $_ ; } else { () } } sort @prs;
     # discard PR numbers below 10000 because they are probably accidents like github pull-requests
     @prs = grep { $_ > 10000 } @prs;
+    # if more than 3 PRs are cited, assume it's an accident like a pkgsrc changelog
+    @prs = () if (@prs > 3);
 
     return @prs;
 }


Home | Main Index | Thread Index | Old Index