Re: CVS commit: src/usr.sbin/sysinst

[christos%astron.com@localhost (Christos Zoulas)]

In article <20150509061542.222719A%cvs.netbsd.org@localhost>,
Martin Husemann <source-changes-d%NetBSD.org@localhost> wrote:
>-=-=-=-=-=-
>
>Module Name:	src
>Committed By:	martin
>Date:		Sat May  9 06:15:42 UTC 2015
>
>Modified Files:
>	src/usr.sbin/sysinst: Makefile.inc
>
>Log Message:
>Make gcc generate better debug info when building with DEBUG set.
>
>
>To generate a diff of this commit:
>cvs rdiff -u -r1.5 -r1.6 src/usr.sbin/sysinst/Makefile.inc
>
>Please note that diffs are not public domain; they are subject to the
>copyright notices on the relevant files.
>
>
>-=-=-=-=-=-
>
>Modified files:
>
>Index: src/usr.sbin/sysinst/Makefile.inc
>diff -u src/usr.sbin/sysinst/Makefile.inc:1.5
>src/usr.sbin/sysinst/Makefile.inc:1.6
>--- src/usr.sbin/sysinst/Makefile.inc:1.5	Wed Aug  6 12:16:12 2014
>+++ src/usr.sbin/sysinst/Makefile.inc	Sat May  9 06:15:42 2015
>@@ -1,4 +1,4 @@
>-#	$NetBSD: Makefile.inc,v 1.5 2014/08/06 12:16:12 martin Exp $
>+#	$NetBSD: Makefile.inc,v 1.6 2015/05/09 06:15:42 martin Exp $
> #
> # Makefile for sysinst
> 
>@@ -55,7 +55,12 @@ CPPFLAGS+=	-I. -I${.CURDIR}/../.. -I${.C
> 		-DCATALOG_DIR=\"${CATALOGDIR}\"
> 
> .if (defined(DEBUG))
>-CPPFLAGS+=-DDEBUG -g -O0
>+.if ${ACTIVE_CC} == "gcc"
>+# make gcc run additional passes for better debug info (only needed
>+# when compiling with -O0)
>+O0TRACKING=	-fvar-tracking-assignments -fvar-tracking
>+.endif
>+CPPFLAGS+=-DDEBUG -g -O0 ${O0TRACKING}
> .endif

Doesn't the -g -O0 belong in ${DBG}?
Also, perhaps O0TRACKING can be automatically provided if ${DBG} has
-O0 in the *.mk files?

christos