Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/dev/bluetooth



On May 8, 12:05pm, max%M00nBSD.net@localhost (Maxime Villard) wrote:
-- Subject: Re: CVS commit: src/sys/dev/bluetooth

| Why didn't you put a goto out here:
| 
| 1369:                if (_m->m_len < 0)
| 1370:                        return false;

I missed it. I don't know if the test is valid though. If this condition
is true it should probably cause an assert... The standard mbuf operations
don't check for this. Nevertheless I will fix it to be consistent for now.

christos


Home | Main Index | Thread Index | Old Index