Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/distrib/atari/floppies/install



joerg@ wrote:

> > "Please don't commit untested and broken fix."
> > "Please file a PR instead if you can't test it."
> 
> I agree with Christos that leaving the build broken is worse.  The
> alternative band aids are much more involved, too. That shouldn't stop
> the second point from that list.

If you claim leaving the build broken is worse than commiting untested code,
you should ask to update our commit guideline first:

http://www.netbsd.org/developers/commit-guidelines.html
>> 1. Commit only code you are familiar with.
>> If you are not sure if the code you plan to commit is acceptable
>> (e. g. when taking code that was submitted with a problem report),
>> ask a developer who is familiar with that part of the system for
>> review.
 :
>> 5. Commit only code that you have tested.
>> Make sure that your code actually works as expected, by compiling
>> and running the code that is affected by your change with your
>> system's tools.

---
Izumi Tsutsui


Home | Main Index | Thread Index | Old Index