Re: CVS commit: src/sys/dev/ic (spdmem.c)

[Masanobu SAITOH <msaitoh%execsw.org@localhost>]

Hi, Paul.

On 2015/04/01 13:57, Paul Goyette wrote:
> > Module Name:    src
> > Committed By:   msaitoh
> > Date:           Fri Mar 27 05:33:08 UTC 2015
> >
> > Modified Files:
> >         src/sys/dev/ic: spdmem.c spdmemreg.h
> >
> > Log Message:
> > Add DDR4 support a bit.
>
>
> Looking at the actual code change here
>
> @@ -76,6 +76,7 @@ static const char* spdmem_basic_types[]
>       "DDR2 SDRAM FB",
>       "DDR2 SDRAM FB Probe",
>       "DDR3 SDRAM"
> +    "DDR4 SDRAM"
>   };
>
>   static const char* spdmem_superset_types[] = {
>
>
> There appears to be a missing comma, leading to the bug I just reported in
>
> http://mail-index.netbsd.org/current-users/2015/04/01/msg027013.html
>
>
>
> :)
>
>
> I would fix it myself, but currently my NetBSD machine is not networked.

 Thank you.

 A few weeks ago, I got a 2-way Xeon machine to test Intel X540 support.
Afrer finishing X540 test, I noticed that the machine had DDR4. I tried
to check the spdmem. It seemed that the machine's spdmem is not connected
via C612's internal i2c bus but via others. I stopped writing DDR4 support
and just added the basic types only because I couldn't test with the machine.

The machine was returned today.

Thanks.

> -------------------------------------------------------------------------
> | Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:       |
> | (Retired)        | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com    |
> | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net |
> | Kernel Developer |                          | pgoyette at netbsd.org  |
> -------------------------------------------------------------------------


--
-----------------------------------------------
                SAITOH Masanobu (msaitoh%execsw.org@localhost
                                 msaitoh%netbsd.org@localhost)