Re: CVS commit: src/sys/ufs/ffs

[christos%astron.com@localhost (Christos Zoulas)]

In article <26607.1424011144%splode.eterna.com.au@localhost>,
matthew green  <mrg%eterna.com.au@localhost> wrote:
>
>> > Also, I think you might want to keep the print when the
>> > checksum is wrong.
>> 
>> If we keep this print, then we keep a lot of other prints. So we don't
>keep it.
>
>i don't follow.
>
>usually these messages are the only real indication of what is
>actually wrong, and they aren't log spew problems.
>
>what are you trying to solve by removing them?  and what is this
>list of "lot of other prints"?  each one should be considered on
>its own pros/cons.

I agree, the printfs are VERY useful. They are the only indication
to what's wrong when mount returns EINVAL. If you are mounting a filesystem
and it does not work, you usually end up putting them back :-)

christos