Re: CVS commit: src/sys/ufs/ffs

[David Holland <dholland-sourcechanges%netbsd.org@localhost>]

On Sat, Feb 14, 2015 at 08:07:39AM +0000, Maxime Villard wrote:
 > Modified Files:
 > 	src/sys/ufs/ffs: ffs_appleufs.c
 > 
 > Log Message:
 > ffs_appleufs_validate():
 >  - remove superfluous printfs
 >  - ensure ul_namelen!=0, otherwise the kernel accesses ul_name[-1] and
 >    overwrites the previous field in the structure.

Did you test this? It is almost certain that this bit:

        *n = *o;
-       n->ul_checksum = 0;
        n->ul_checksum = ffs_appleufs_cksum(n);

breaks it. Also, I think you might want to keep the print when the
checksum is wrong.

-- 
David A. Holland
dholland%netbsd.org@localhost