Re: CVS commit: src

[David Laight <david%l8s.co.uk@localhost>]

On Fri, Jan 02, 2015 at 06:11:48PM +0200, Alan Barrett wrote:
> On Fri, 02 Jan 2015, Christos Zoulas wrote:
> >>>Log Message:
> >>>Implement DIOCGMEDIASIZE and DIOCGSECTORSIZE from FreeBSD.
> >>
> >>This needs compat32 handling, at least for the u_int arg to
> >>DIOCGSECTORSIZE.
> >>
> >>Why not make it a fixed size, like uint32_t, so compat32 handling will
> >>not be needed?
> >
> >I think it was made u_int to match previous art by FreeBSD. Can you please
> >explain why it needs compat32 handling?
> 
> Sorry, it doesn't need compat32 handling, because all existing
> NetBSD platforms have 32-bit int, and all exiting NetBSD platforms
> have 64-bit off_t.

Specifying uint32_t and ensuring that 64bit fields are 'aligned'
is good practice and does no harm.

	David

-- 
David Laight: david%l8s.co.uk@localhost