Re: CVS commit: src/sys/arch/atari/stand/installboot

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

christos@ wrote:

> |  http://mail-index.netbsd.org/source-changes-d/2014/11/15/msg007338.html
> 
> I could not have tested; I asked you to test.

I didn't tested it either.
I noticed your obvious wrong pointer calculation by code inspection,
and it means memcpy() would confuse future maintainers "which address
should be used for the cksum."

> | If you still don't like it, please propose a patch which satisfies
> | both requests as martin said, not repeating your "memcpy is ok and
> | -fstrict-aliasing is more important" claim.
> 
> I did not propose that one but the be16enc() solution someone else
> presented seems more natural (and will work on LE machines).

You still don't understand my point:
"to use u_int16_t assignment consistently."
be16enc() is a bit better them memcpy(), but not ok for me.

memcpy() and be16enc() are functions to access stream buffers.
The cksum should be an element of u_int16_t array, not part of stream
in this case.

---
Izumi Tsutsui