Re: CVS commit: src/sys

[Takeshi Nakayama <tn%catvmics.ne.jp@localhost>]

>>> Antti Kantee <pooka%iki.fi@localhost> wrote

> On 15/11/14 23:46, Takeshi Nakayama wrote:
> >>>> Justin Cormack <justin%specialbusservice.com@localhost> wrote
> >
> >> Er, you can't do that.
> >>
> >> 1. It breaks the rump builds on most platforms
> >> http://build.myriabit.eu:8012/waterfall as the prototypes dont match
> >> eg see http://build.myriabit.eu:8012/builders/ppc64-cross/builds/5585/steps/shell_3/logs/stdio
> >
> > It seems that posix says 2nd arg of iconv(3) is char **, but
> > NetBSD's one is const char **.
> >
> >> 2. There is no requirement that rump runs on a platform that has iconv
> >> anyway, it may be running on bare metal, or non Posix platform.
> >>
> >> Not sure what the intention was though - I am sure we can find a way
> >> around it...
> >
> > I would like to include this at least on NetBSD host since we don't
> > have kernel iconv and then mount_smbfs(8) is useless for filename
> > conversions.
> >
> > So is it ok to add a compile-time option as below and define it
> > somewhere?  Or are there any more appropriate make variables to
> > detect host OS?
> 
> Is the effect that the smbfs driver has more functionality when it is 
> run in a rump kernel than when it is run in the NetBSD kernel?  That is 
> not a good change.  In addition to reason "2" cited above, there is a 
> usability problem: mount with and without "-o rump" is supposed to 
> provide the same functionality.  If "-o rump" starts meaning "with 
> working iconv", it will make configuration and documentation difficult.

I plan to add the following lines to mount_smbfs(8).  The -E option
was the same as -c before my change was commited.

| BUGS
|      The -E option works only if you mount with rump_smbfs(8) instead of
|      mount_smbfs.
| 
|      The -c option is not implemented yet.  It is silently ignored for now.

> While it is possible to add compile-time conditionals to the effect that 
> your change does not per se break anything, I would rather see a fix 
> which also works with mount_smbfs.

It is not easy to work, so I think it is a good idea to work
partially using rump kernel.

-- Takeshi Nakayama