Re: CVS commit: src/sys/arch

[Masao Uebayashi <uebayasi%gmail.com@localhost>]

On Sun, Oct 19, 2014 at 12:15 PM, John Nemeth <jnemeth%cue.bc.ca@localhost> wrote:
> On Oct 18,  4:56pm, "Masao Uebayashi" wrote:
> }
> } Module Name:  src
> } Committed By: uebayasi
> } Date:         Sat Oct 18 16:56:51 UTC 2014
> }
> } Modified Files:
> }       src/sys/arch/amd64/conf: ALL GENERIC XEN3_DOM0
> }       src/sys/arch/i386/conf: ALL GENERIC INSTALL_FLOPPY XEN3_DOM0
> }       src/sys/arch/x86/pci: files.pci
> }
> } Log Message:
> } Install agp_* drivers where pchb(4) is installed except INSTALL_FLOPPY.
> }
> } XXX
> } Config around agp(4) is done in quite wrong direction.
> }       "pchb <- (agpbus) <- agp <- agp_*"
> } should be:
> }       "pchb <- (pcibus) <- agp_* <- (agpbus) <- agp"
>
>      No, it should NOT!  AGP does NOT hang off a PCI bus.  It is a
> seperate bus that sits beside PCI.

Understood.  But still, agp.c is under sys/dev/pci; and its
configuration is common to PCI, right?

And, agp_* should pass function pointers to agp via attach args so
that #ifdef NAGP_* in agp.c can go away.