Re: CVS commit: src/sys/arch/evbarm/rpi

[christos%astron.com@localhost (Christos Zoulas)]

In article <20140928143829.88F364F%cvs.netbsd.org@localhost>,
Michael Lorenz <source-changes-d%NetBSD.org@localhost> wrote:
>-=-=-=-=-=-

>+	hcursor = rpi_alloc_mem(64 * 64 * 4, PAGE_SIZE,
>+	    MEM_FLAG_L1_NONALLOCATING | MEM_FLAG_HINT_PERMALOCK);

Can you put some constants here since this 64 * 64 * 4 gets repeated?
Maybe one constant for 64 and one for the whole thing?

>+		int i, j, k;

uint32_t for the indexes?

>+		copyin(cur->mask, cursor_mask, 64 * 8);
>+		copyin(cur->image, cursor_bitmap, 64 * 8);

Error checking? More constants?

>+		int i, j, idx;

uint32_t for the indexes?


christos