Re: CVS commit: src/sys/dev/pci

To: Maxime Villard <max%M00nBSD.net@localhost>, source-changes-d%NetBSD.org@localhost
Subject: Re: CVS commit: src/sys/dev/pci
From: christos%zoulas.com@localhost (Christos Zoulas)
Date: Sat, 27 Sep 2014 11:45:14 -0400

On Sep 27,  3:44pm, max%M00nBSD.net@localhost (Maxime Villard) wrote:
-- Subject: Re: CVS commit: src/sys/dev/pci

| This fix is wrong.
| 
| -	memset(p, sizeof(struct twa_param_9k *), 10);
| +	memset(p, 0, sizeof(*p));
| 
| p is a [10] array, your memset only initializes the first pointer.
| 
| Seriously, guy, ...

Yes, this is the case where *p is wrong. Thank c for making this inconsistent!

christos

References:
- Re: CVS commit: src/sys/dev/pci
  - From: Maxime Villard

Prev by Date: Re: CVS commit: src/lib/libc/gen
Next by Date: Re: CVS commit: src/sys/arch/xen/xen
Previous by Thread: Re: CVS commit: src/sys/dev/pci
Indexes:

Home | Main Index | Thread Index | Old Index