Re: CVS commit: src/sys/arch/atari/atari

[Maxime Villard <max%M00nBSD.net@localhost>]

Le 21/09/2014 17:49, Christos Zoulas a écrit :
> 
> Module Name:	src
> Committed By:	christos
> Date:		Sun Sep 21 15:49:21 UTC 2014
> 
> Modified Files:
> 	src/sys/arch/atari/atari: intr.c
> 
> Log Message:
> fix leak.
> 
> 
> To generate a diff of this commit:
> cvs rdiff -u -r1.23 -r1.24 src/sys/arch/atari/atari/intr.c
> 
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
> 
> 

My scanner forgets variables as soon as a bug is detected with them.
Which means that only the first leak is reported.

In this file there's another leak below (not tested):

Index: atari/intr.c
===================================================================
RCS file: /cvsroot/src/sys/arch/atari/atari/intr.c,v
retrieving revision 1.24
diff -u -r1.24 intr.c
--- atari/intr.c	21 Sep 2014 15:49:21 -0000	1.24
+++ atari/intr.c	26 Sep 2014 15:53:18 -0000
@@ -141,8 +141,10 @@
 		ih->ih_intrcnt = &intrcnt_auto[vector-1];
 		break;
 	case USER_VEC:
-		if (vector < UVEC_MIN || vector > UVEC_MAX)
+		if (vector < UVEC_MIN || vector > UVEC_MAX) {
+			free(ih, M_DEVBUF);
 			return NULL;
+		}
 		vec_list = &uservec_list[vector];
 		hard_vec = &uservects[vector];
 		ih->ih_intrcnt = &intrcnt_user[vector];