Re: CVS commit: src/lib/libc/gen

[Roy Marples <roy%marples.name@localhost>]

On 2014-09-26 15:09, Alan Barrett wrote:
> On Fri, 26 Sep 2014, Roy Marples wrote:
> > Modified Files:
> > 	src/lib/libc/gen: unvis.c
> >
> > Log Message:
> > Remove \$ as a hidden marker as vis(3) wasn't setting it
> > and it clobbered VIS_SHELL | VIS_CSTYLE.
>
> This is wrong.  "vis -l" outputs \$, and with this change, unvis won't
> correctly handle it.
>
> unvis is not intended to reverse shell-style escapes.  You can use
> the shell's eval command for that.

Doesn't eval kind of defeat the purpose of shell sanitisation which 
VIS_SHELL is supposed to achieve?
I can always add $ to "the don't encode this" list for VIS_CSTYLE.