Re: CVS commit: src/sys/netinet

[Erik Fair <fair%netbsd.org@localhost>]

This should be pulled up to netbsd-6

On Apr 12, 2014, at 05:24, Greg Troxel <gdt%netbsd.org@localhost> wrote:

> Module Name:  src
> Committed By: gdt
> Date:         Sat Apr 12 12:24:50 UTC 2014
> 
> Modified Files:
>       src/sys/netinet: if_arp.c
> 
> Log Message:
> revarprequest: Avoid leaking mbuf.
> 
> In revarprequest, an mbuf could perhaps be leaked in an error path.
> My reading of the code is that this is not possible, because ar_pro is
> set to ETHERNET_IP, and ar_tha can only be null in the 1394 case.
> But, better to have the free call anyway; ar_tha does not have a
> documented interface contract :-)
> 
> Pointed out by Maxime Villard.
> 
> 
> To generate a diff of this commit:
> cvs rdiff -u -r1.155 -r1.156 src/sys/netinet/if_arp.c
> 
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
>