re: CVS commit: src/external/mit/xorg/bin/xauth

[christos%zoulas.com@localhost (Christos Zoulas)]

On Apr 6,  9:31am, mrg%eterna.com.au@localhost (matthew green) wrote:
-- Subject: re: CVS commit: src/external/mit/xorg/bin/xauth

| it shows xauth doing this:
| 
| unlink("/home/foo/.Xauthority");
| link("/home/foo/.Xauthority", "/home/foo/.Xauthority");
| 
| which is where it fails.
| 
| the code itself clearly can't be responsible for this, it is
| using a -c or -n additional postfix on the filename for the
| 'src' link above, which isn't present.
| 
| at least, that appears to be the intent ;)

Someone pointed out the bug to me. Our stpcpy_chk() was off by one.
gcc-4.8 changes:

        strcpy(dst, ...); l = strlen(dst);
to
        x = stpcpy(dst, ...); l = x - dst;

if you update and rebuild libc, xauth should work again.


christos