Re: CVS commit: src/games/hunt/huntd

[David Holland <dholland-sourcechanges%netbsd.org@localhost>]

On Fri, Mar 28, 2014 at 05:49:11PM +0000, Alan Barrett wrote:
 > Module Name: src
 > Committed By:        apb
 > Date:                Fri Mar 28 17:49:11 UTC 2014
 > 
 > Modified Files:
 >      src/games/hunt/huntd: get_names.c
 > 
 > Log Message:
 > If you are going to use memcpy instead of struct assignment, then at
 > least use sizeof(the correct variable).  The use of memcmp to test
 > two pointers for equality, one line earlier, is also weird but may be
 > correct.

My todo file for huntd (dated 2009) says:

   get_remote_name():
        his_address, his_name, his_machine_name, ptr should be const
        really stupid memcmp() call
        following memcpy is also wrong

I have no idea why I didn't fix it when I found it.

-- 
David A. Holland
dholland%netbsd.org@localhost