Taylor R Campbell <campbell+netbsd-source-changes-d%mumble.net@localhost> writes: > Date: Wed, 12 Mar 2014 16:16:32 +0200 > From: Jukka Ruohonen <jruohonen%iki.fi@localhost> > > On Wed, Mar 12, 2014 at 09:39:23AM +0000, Juergen Hannken-Illjes wrote: > > Restructure layer_lock() to always lock before testing for dead node. > > Use ISSET() to test flags, add assertions. > > As I wrote in the manual page, I'd rather see ISSET(3) et. al. disappear, > i.e. these obscure rather than clarify... > > I disagree. Phrases like `(vp->v_iflag & (VI_XLOCK | VI_CLEAN)) == 0' > make my head's parser stumble -- there are just enough complements to > juggle that it overwhelms my brain registers for the fast path. I'd > rather read `!ISSET(vp->v_iflag, (VI_XLOCK | VI_CLEAN))'. FWIW, I agree with Taylor.
Attachment:
pgpQqSDMvrUl4.pgp
Description: PGP signature