Re: CVS commit: src/sys/external/bsd/compiler_rt/dist/lib

[christos%astron.com@localhost (Christos Zoulas)]

In article <20140218222555.GB1915%britannica.bec.de@localhost>,
Joerg Sonnenberger  <joerg%britannica.bec.de@localhost> wrote:
>On Tue, Feb 18, 2014 at 03:53:44PM -0500, Christos Zoulas wrote:
>> Module Name: src
>> Committed By:        christos
>> Date:                Tue Feb 18 20:53:44 UTC 2014
>> 
>> Modified Files:
>>      src/sys/external/bsd/compiler_rt/dist/lib: int_util.c
>> 
>> Log Message:
>> - include <sys/cdefs.h> for compiler definitions
>> - add a lint comment
>
>Please revert this, it doesn't add value and it makes it harder to deal
>with prestine upstream. More importantly, please bring up such changes
>upstream first.

What's the upstream? In this particular case we depend on <sys/cdefs.h>
to define __attribute__() and other extensions properly for compilers
that don't have it. How else do you propose to fix it? Or are you saying
everything needs to support all the gcc/clang extensions?

christos